Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authentication #73

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Fix authentication #73

merged 2 commits into from
Jul 17, 2023

Conversation

stijndcl
Copy link
Contributor

Fixes #72

The NewAuthenticator now takes a subdomain argument to send the requests. Beforehand, all requests failed because of an invalid URL.

I removed the parameter from RevokeToken() because it wasn't being used anyway. Docs were updated accordingly.

@Jmfwolf
Copy link
Contributor

Jmfwolf commented Jul 17, 2023

I will correct the testing issue after the PR

@Jmfwolf Jmfwolf merged commit cf20670 into onelogin:develop Jul 17, 2023
@stijndcl stijndcl deleted the fix-authentication branch July 17, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jmfwolf Jmfwolf Jmfwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Authentication fails because of incorrect API url
2 participants
@stijndcl @Jmfwolf